Fix keyboard events for Backspace/Delete keys #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CDP's Input.dispatchKeyEvent requires windowsVirtualKeyCode for non-character keys like Backspace (8) and Delete (46) to work properly. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Contributor
|
@gdaybrice is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| code: params.code, | ||
| text: params.text, | ||
| windowsVirtualKeyCode: params.keyCode, | ||
| nativeVirtualKeyCode: params.keyCode, |
Contributor
There was a problem hiding this comment.
Suggested change
| nativeVirtualKeyCode: params.keyCode, |
Incorrectly setting both windowsVirtualKeyCode and nativeVirtualKeyCode to the same Windows key code value, causing keyboard events to not work correctly on non-Windows platforms (macOS, Linux)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
keyCodeparameter toinjectKeyboardEventto passwindowsVirtualKeyCodeandnativeVirtualKeyCodeto CDPInputKeyboardMessageinterface to includekeyCodekeyCodefrom WebSocket message to the keyboard event handlerProblem
Backspace and Delete keys were not working when using the streaming server. CDP's
Input.dispatchKeyEventrequireswindowsVirtualKeyCodefor non-character keys like Backspace (keyCode 8) and Delete (keyCode 46) to function properly.